Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export gcs options #30772

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Export gcs options #30772

wants to merge 3 commits into from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Mar 27, 2024

Allow Customers to pass GIB.WSK parameters for the write File transform.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Mar 27, 2024
@Naireen Naireen force-pushed the export_gcs_options branch 4 times, most recently from 5f0a7fd to 0928146 Compare March 27, 2024 22:24
@Naireen
Copy link
Contributor Author

Naireen commented Mar 28, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 28, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 28, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 28, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 29, 2024

Run Java PreCommit

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (2f8854a) to head (91ffa17).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30772      +/-   ##
============================================
- Coverage     71.47%   70.85%   -0.62%     
- Complexity        0     2983    +2983     
============================================
  Files           710     1062     +352     
  Lines        104815   132683   +27868     
  Branches          0     3230    +3230     
============================================
+ Hits          74915    94012   +19097     
- Misses        28268    35576    +7308     
- Partials       1632     3095    +1463     
Flag Coverage Δ
java 68.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Naireen
Copy link
Contributor Author

Naireen commented Mar 29, 2024

Run Java_IOs_Direct PreCommit

1 similar comment
@Naireen
Copy link
Contributor Author

Naireen commented Mar 29, 2024

Run Java_IOs_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Mar 29, 2024

Test seems flaky, will try rerunning again:

@Naireen
Copy link
Contributor Author

Naireen commented Mar 29, 2024

Run Java_IOs_Direct PreCommit

@Naireen Naireen marked this pull request as ready for review April 1, 2024 17:04
@Naireen
Copy link
Contributor Author

Naireen commented Apr 1, 2024

Checks are passing, the one failing is for parsing test results (saying the file is too large: https://github.com/apache/beam/pull/30772/checks?check_run_id=23251024301)

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Naireen
Copy link
Contributor Author

Naireen commented Apr 2, 2024

assign set of reviewers

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @bvolpato

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (2f8854a) to head (91ffa17).
Report is 216 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30772      +/-   ##
============================================
- Coverage     71.47%   70.85%   -0.62%     
- Complexity        0     2983    +2983     
============================================
  Files           710     1062     +352     
  Lines        104815   132683   +27868     
  Branches          0     3230    +3230     
============================================
+ Hits          74915    94012   +19097     
- Misses        28268    35576    +7308     
- Partials       1632     3095    +1463     
Flag Coverage Δ
java 68.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Reminder, please take a look at this pr: @bvolpato

@Naireen
Copy link
Contributor Author

Naireen commented Apr 18, 2024

R: @scwhittle

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@@ -175,6 +175,9 @@ public static <UserT, DestinationT, OutputT> WriteFiles<UserT, DestinationT, Out
.setSkipIfEmpty(false)
.setBadRecordErrorHandler(new DefaultErrorHandler<>())
.setBadRecordRouter(BadRecordRouter.THROWING_ROUTER)
.setFileTriggeringRecordCount(FILE_TRIGGERING_RECORD_COUNT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of repeating these everywhere we create the builder how about creating a static create method that constructs the builder and adds defaults instead of calling the builder constructor directly. Could unify the other defaults as well.

pseudocode:
in AutoValue_WriteFiles.Builder

static Builder create() {
return new AutoValue_WriteFiles.Builder<UserT, DestinationT, OutputT>.Builder()
.setFileTriggeringByteCount(FILE_TRIGGERING_BYTE_COUNT) // 64MiB as of now
}

and make constructor private

I believe that you can override th builder constructor to set the defaults. That seems better in that it will have a single location instead of duplicated across different files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants