Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beam 1702] Add support for local execution to BigtableIO using the google cloud emulator #3078

Closed
wants to merge 2 commits into from

Conversation

hepeknet
Copy link

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-1702>] Add support for local execution to BigtableIO using the google cloud emulator
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@iemejia @dhalperi please check - thanks


@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 70.171% when pulling a2be994 on hepeknet:BEAM-1702 into 15bd3a3 on apache:master.

@dhalperi
Copy link
Contributor

Please separate this into 2 PRs -- one for javadoc and one for autovalue. These are two separate features that should be judged independently.

@hepeknet
Copy link
Author

@dhalperi I created #3113 - after that is merged I will modify this PR and resubmit...

hope that makes sense...

cheers

@iemejia
Copy link
Member

iemejia commented May 14, 2017

I was away last week so I couldn't follow this discussion, thanks @hepekhe for bringing this info (the documentation on how to make both IOs work with the google emulators).
One extra slightly related question. Have you tested the DatastoreIO with the Datastore emulator? (When I tried it didn't work, but I haven't checked recently).

@hepeknet
Copy link
Author

Hi @dhalperi did not check DataStore - will do that today and let you know.

@hepeknet hepeknet closed this May 15, 2017
@hepeknet
Copy link
Author

Closed - will submit new one containing only localhost options

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.225% when pulling 4eac730 on hepeknet:BEAM-1702 into 9a43da7 on apache:master.

@hepeknet
Copy link
Author

Hi @iemejia I just tested DataStoreIO and it works with local emulator... at least basic reading and writing..using withLocalhost() does all the work... will play with it a bit

@iemejia
Copy link
Member

iemejia commented May 16, 2017

Thanks a lot for checking that DataStoreIO works ok and for all the other contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants