Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #3080 into release-2.0.0 #3081

Closed

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented May 11, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

[BEAM-2259] Use a consistent calculation for GC Time

Truncate all garbage collection timestamps to be at the end of the
global window at the latest.

Add a reshuffle test, which was failing when late data arrived.

Update ReifyTimestamps to permit infinite skew. Elements that have
timestamps extracted from them may be late, but that is not the concern
of ReifyTimestamps.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fb986b on tgroh:reshuffle_exception_release into ** on apache:release-2.0.0**.

Truncate all garbage collection timestamps to be at the end of the
global window at the latest.

Add a reshuffle test, which was failing when late data arrived.

Update ReifyTimestamps to permit infinite skew. Elements that have
timestamps extracted from them may be late, but that is not the concern
of ReifyTimestamps.
@tgroh tgroh force-pushed the reshuffle_exception_release branch from 6fb986b to e70fc86 Compare May 11, 2017 19:27
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e70fc86 on tgroh:reshuffle_exception_release into ** on apache:release-2.0.0**.

@tgroh
Copy link
Member Author

tgroh commented May 11, 2017

R: @davorbonaci

@dhalperi
Copy link
Contributor

LGTM as valid CP of #3080. Merging as both are green.

asfgit pushed a commit that referenced this pull request May 11, 2017
@tgroh
Copy link
Member Author

tgroh commented May 11, 2017

merged to release, closing

@tgroh tgroh closed this May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants