New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Web API connector interfaces #30815
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30815 +/- ##
============================================
- Coverage 70.73% 70.72% -0.02%
Complexity 4468 4468
============================================
Files 1256 1257 +1
Lines 140774 140856 +82
Branches 4306 4306
============================================
+ Hits 99581 99622 +41
- Misses 37714 37745 +31
- Partials 3479 3489 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30815 +/- ##
============================================
- Coverage 71.44% 70.72% -0.73%
- Complexity 1474 4468 +2994
============================================
Files 906 1257 +351
Lines 113271 140856 +27585
Branches 1076 4306 +3230
============================================
+ Hits 80931 99622 +18691
- Misses 30327 37745 +7418
- Partials 2013 3489 +1476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
|
b8e8747
to
485bb4f
Compare
@lostluck This is ready but not urgent. |
Reminder, please take a look at this pr: @jrmccluskey @chamikaramj |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
|
This PR addresses #30423 with the Web API connector interfaces. A future PR will create the actual transform that processes Web API requests into a response PCollection.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.