Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lazy iteration for non-reiterables. #30851

Merged
merged 2 commits into from Apr 5, 2024
Merged

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Apr 4, 2024

In particular Runner v2 does not produce Reiterables, which resulted in the entire stream being read into memory. In this case we can leverage the fact that the first 100MB will be cached and quick to reiterate over.

Formerly, if the underlying iterable was not a reiterable, it would attempt to store the entire thing in memory. Now it will fall back to re-iterating (and filtering) from the start if the iterator does not support iterating from an arbitrary point, which may not be as efficient in some cases, but will not OOM.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Apr 4, 2024
In particular Runner v2 does not produce Reiterables, which
resulted in the entire stream being read into memory. In this case
we can leverage the fact that the first 100MB will be cached and
quick to reiterate over.
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@robertwb
Copy link
Contributor Author

robertwb commented Apr 5, 2024

R: @priyansndesai

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link

@priyansndesai priyansndesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this change. This will be a major unblocker.

@robertwb robertwb merged commit f1a47ef into apache:master Apr 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants