-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle target and github workflow for cross-langauge yaml tests. #30874
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
name: PostCommit Python Xlang Gcp Direct | ||
|
||
on: | ||
pull_request_target: | ||
paths: ['release/trigger_all_tests.json', 'model/**', 'sdks/python/**'] | ||
issue_comment: | ||
types: [created] | ||
push: | ||
tags: ['v*'] | ||
branches: ['master', 'release-*'] | ||
paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml"] | ||
schedule: | ||
- cron: '30 5/6 * * *' | ||
workflow_dispatch: | ||
|
||
#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event | ||
permissions: | ||
actions: write | ||
pull-requests: write | ||
checks: write | ||
contents: read | ||
deployments: read | ||
id-token: none | ||
issues: write | ||
discussions: read | ||
packages: read | ||
pages: read | ||
repository-projects: read | ||
security-events: read | ||
statuses: read | ||
|
||
# This allows a subsequently queued workflow run to interrupt previous runs | ||
concurrency: | ||
group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}' | ||
cancel-in-progress: true | ||
|
||
env: | ||
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} | ||
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} | ||
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} | ||
|
||
jobs: | ||
beam_PreCommit_Yaml_Xlang_Direct: | ||
if: | | ||
github.event_name == 'workflow_dispatch' || | ||
github.event_name == 'pull_request_target' || | ||
(github.event_name == 'schedule' && github.repository == 'apache/beam') || | ||
github.event.comment.body == 'Run Yaml_Xlang_Direct PreCommit' | ||
runs-on: [self-hosted, ubuntu-20.04, main] | ||
timeout-minutes: 100 | ||
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) | ||
strategy: | ||
matrix: | ||
job_name: ["beam_PreCommit_Yaml_Xlang_Direct"] | ||
job_phrase: ["Run Yaml_Xlang_Direct"] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup repository | ||
uses: ./.github/actions/setup-action | ||
with: | ||
comment_phrase: ${{ matrix.job_phrase }} | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) | ||
- name: Setup environment | ||
uses: ./.github/actions/setup-environment-action | ||
with: | ||
python-version: | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we actually need 2 python versions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we're just running against 3.11 here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the gradle commands are using 3.8 by default. We probably don't need both. |
||
3.8 | ||
3.11 | ||
- name: run PostCommit Yaml Xlang Gcp Direct script | ||
uses: ./.github/actions/gradle-command-self-hosted-action | ||
with: | ||
gradle-command: :sdks:python:yamlIntegrationTests | ||
- name: Archive Python Test Results | ||
uses: actions/upload-artifact@v4 | ||
if: failure() | ||
with: | ||
name: Python Test Results | ||
path: '**/pytest*.xml' | ||
- name: Publish Python Test Results | ||
uses: EnricoMi/publish-unit-test-result-action@v2 | ||
if: always() | ||
with: | ||
commit: '${{ env.prsha || env.GITHUB_SHA }}' | ||
comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }} | ||
files: '**/pytest*.xml' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,6 +107,26 @@ tasks.register("generateYamlDocs") { | |
outputs.file "${buildDir}/yaml-ref.html" | ||
} | ||
|
||
tasks.register("yamlIntegrationTests") { | ||
description "Runs integration tests for yaml pipelines." | ||
|
||
dependsOn installGcpTest | ||
// Need to build all expansion services referenced in apache_beam/yaml/*.* | ||
// grep -oh 'sdk.*Jar' sdks/python/apache_beam/yaml/*.yaml | sort | uniq | ||
dependsOn ":sdks:java:extensions:schemaio-expansion-service:shadowJar" | ||
dependsOn ":sdks:java:extensions:sql:expansion-service:shadowJar" | ||
dependsOn ":sdks:java:io:expansion-service:build" | ||
dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build" | ||
|
||
doLast { | ||
exec { | ||
executable 'sh' | ||
args '-c', "${envdir}/bin/pytest -v apache_beam/yaml/integration_tests.py" | ||
} | ||
} | ||
outputs.file "${buildDir}/yaml-ref.html" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this output correct? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed. |
||
} | ||
|
||
// Create Python wheels for given platform and Python version | ||
// build identifiers for cibuildwheel | ||
def platform_identifiers_map = [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this trigger on some java directories too? I think the java directory change is the one that actually caused the failure (and I expect this to generally be the case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It's hard to know where to draw the line. I've added some candidates, and this should get run on postcommit/release as well.