[BEAM-2256] Add the last previous range filter #3093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @dhalperi |
lukecwik
approved these changes
May 11, 2017
| * A MongoDB {@link BoundedSource} reading {@link Document} from a given instance. | ||
| */ | ||
| @VisibleForTesting | ||
| protected static class BoundedMongoDbSource extends BoundedSource<Document> { |
There was a problem hiding this comment.
package private instead of protected
| @@ -294,7 +299,8 @@ public long getEstimatedSizeBytes(PipelineOptions pipelineOptions) { | |||
| * @param additionalFilter A custom (user) additional filter to append to the range filters. | |||
| * @return A list of filters containing the ranges. | |||
| */ | |||
| private static List<String> splitKeysToFilters(List<Document> splitKeys, String | |||
| @VisibleForTesting | |||
| protected static List<String> splitKeysToFilters(List<Document> splitKeys, String | |||
There was a problem hiding this comment.
package private instead of protected
|
|
||
| lowestBound = splitKey; | ||
| } | ||
| return filters; | ||
| } | ||
|
|
||
| /** | ||
| * Cleanly format range filter, eventually adding an user additional filter. |
There was a problem hiding this comment.
nit: adding an user additional filter -> adding the users additional filter
| @@ -306,30 +312,44 @@ public long getEstimatedSizeBytes(PipelineOptions pipelineOptions) { | |||
| // the range from the beginning up to this split | |||
| rangeFilter = String.format("{ $and: [ {\"_id\":{$lte:ObjectId(\"%s\")}}", | |||
| splitKey); | |||
| filters.add(formatFilter(rangeFilter, additionalFilter)); | |||
| } else if (i == splitKeys.size() - 1) { | |||
| // this is the last split in the list, the filter defines | |||
There was a problem hiding this comment.
The comment should mention that we have two splits when dealing with the last element.
| @@ -294,7 +299,8 @@ public long getEstimatedSizeBytes(PipelineOptions pipelineOptions) { | |||
| * @param additionalFilter A custom (user) additional filter to append to the range filters. | |||
| * @return A list of filters containing the ranges. | |||
| */ | |||
| private static List<String> splitKeysToFilters(List<Document> splitKeys, String | |||
| @VisibleForTesting | |||
| protected static List<String> splitKeysToFilters(List<Document> splitKeys, String | |||
There was a problem hiding this comment.
optional: Add a precondition that checks that splitKeys is not empty since this method does not correctly handle the empty splitKeys case.
|
R: @lukecwik |
|
@jbonofre I will address the comments I made and will get it merged. |
|
This has been merged, please close PR. |
asfgit
pushed a commit
that referenced
this pull request
May 11, 2017
|
Thanks @lukecwik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.