Fix broken lint and improve lint rules. #30940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
force-pushed
the
whitespace_lints
branch
from
c60bf31
to
1d1f30d
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
liferoad
approved these changes
Apr 12, 2024
|
cc @akashorabek |
|
@tvalentyn @liferoad Seems one of the checks has failed. Shall we merge it as it is or re-run it manually? Notice that there is no way to re-run it by leaving a comment |
|
Closed and reopened to retrigger tests |
|
local environment test fail should be irrelevant, merging for now |
je-ik
pushed a commit
to je-ik/beam
that referenced
this pull request
Apr 15, 2024
* Enable lint for all gradle and kts files * Fix lint.
bzablocki
pushed a commit
to bzablocki/beam
that referenced
this pull request
Apr 16, 2024
* Enable lint for all gradle and kts files * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint got broken by #30886 , but lint check didn't run on that PR.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.