Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting metrics not supported warning for BigQueryIO Direct read when throttled #31096

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 24, 2024

Fixes #30646. Actually the feature is there but there is a bug prevented it from working properly.

The pipeline, when throttled, can see warning

Reporting metrics are not supported in the current execution environment.

raised from here:

This is because the method is called on a callback thread that does not have thread level metrics container. Change it to increment the metrics back to StorageClientImpl temporarily then add it to Beam metrics in work item thread resolved the issue.

Tested with reading TPCDS_1T

Before (pipeline throttled, slowdown, scheduler aggressively upscale worker):

image

  • max worker 106

After (pipeline actively scale down, throttling metrics shown)

image

  • throttling-msecs 15,060,000
  • max worker: 57

Sufficient quota:

image

  • max worker: 43

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

When throttled. This fixes throttling based autoscaling for BigQueryIO
DIRECT_READ pipeline on Dataflow
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Apr 25, 2024

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Apr 25, 2024

macos java unit test failed due to #31100 - and rerun doesn't work because the base branch of this PR wasn't updated

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for this fix!

@Abacn Abacn merged commit c20e329 into apache:master Apr 26, 2024
15 of 17 checks passed
@Abacn Abacn deleted the bq-readapi-thrott branch April 26, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Client-side throttling for BigQueryIO DIRECT_READ mode
2 participants