-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubsubIO: add readMessagesWithAttributesWithCoderAndParseFn #31206
PubsubIO: add readMessagesWithAttributesWithCoderAndParseFn #31206
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
18cf95a
to
321180c
Compare
Some checks are failing with
Doesn't seem to relate to the changes in this PR. assign set of reviewers |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reviewers are already assigned to this PR: @m-trieu @johnjcasey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL @johnjcasey @scwhittle
.../java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
Show resolved
Hide resolved
5667062
to
e84f562
Compare
67662cd
to
6b0a15c
Compare
...a/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
Outdated
Show resolved
Hide resolved
...a/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
Outdated
Show resolved
Hide resolved
.../java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
Show resolved
Hide resolved
6b0a15c
to
a5f80ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Will merge once presubmits have a chance to complete |
This change adds
readMessagesWithAttributesWithCoderAndParseFn
that enables forwarding of the Pubsub message attributes to make them available when applying the provided ParseFn. The new method is similar toreadMessagesWithCoderAndParseFn
, but addssetNeedsAttributes(true)
.Why?
The
readMessagesWithCoderAndParseFn
of PubsubIO skips forwarding the pubsub message attributes to the provided parse function. In the use case I am solving, the attributes of the message contain the schema fingerprint needed for the parsing.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.