Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a deprecated test helper. #31236

Merged
merged 2 commits into from
May 10, 2024
Merged

Remove a deprecated test helper. #31236

merged 2 commits into from
May 10, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented May 9, 2024 •
edited

fixes: #31048

@github-actions github-actions bot added the python label May 9, 2024
@tvalentyn tvalentyn mentioned this pull request May 9, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

jrmccluskey
jrmccluskey approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn tvalentyn merged commit 0a58d7d into apache:master May 10, 2024
74 checks passed
@tvalentyn tvalentyn deleted the unittest branch May 10, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmccluskey jrmccluskey jrmccluskey approved these changes

Assignees
No one assigned
Labels
Next Action: Reviewers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Remove usages of a deprecated test helper assertDictContainsSubset in Beam codebase.
2 participants
@tvalentyn @jrmccluskey