New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-2024] internal comments #3128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -37,6 +37,7 @@ | |||
from apache_beam.utils.timestamp import MAX_TIMESTAMP | |||
from apache_beam.utils.timestamp import MIN_TIMESTAMP | |||
|
|||
# AfterCount is experimental. No backwards compatibility guarantees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the docstring of AfterCount as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
PTAL |
(Local run of the tests passed.) |
(Merging.) |
R: @robertwb
cc: @davorbonaci (comment only change, if we can pick to the release branch, it is ok if it is too late.)