Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MultimapKeysSideInput in State GetRequests #31632

Merged

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jun 18, 2024

This PR closes #31628 adding handling for MultimapKeysSideInput in State GetRequests. Since this surfaced in Java validation tests of org.apache.beam.sdk.transforms.ViewTest, validated on Prism via:

TEST=org.apache.beam.sdk.transforms.ViewTest
./gradlew :runners:portability:java:ulrLoopbackValidatesRunnerTests -PjobEndpoint=localhost:8073 --tests="$TEST"

This PR fixes the following ViewTest tests:

  • testMapAsEntrySetSideInput
  • testWindowedMultimapAsEntrySetSideInput
  • testWindowedMapAsEntrySetSideInput
  • testMultimapAsEntrySetSideInput

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review June 19, 2024 20:38
@damondouglas
Copy link
Contributor Author

R: @lostluck

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after import fix.

@damondouglas damondouglas merged commit c6c3fd0 into apache:master Jun 21, 2024
7 checks passed
@damondouglas damondouglas deleted the prism-map-sideinput-state-keys branch June 21, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Side Input Keys
2 participants