[BEAM-2406] Fix NullPointerException when writing an empty table #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjchambers
reviewed
Jun 5, 2017
| @@ -79,6 +80,7 @@ | |||
| public final DestinationT destination; | |||
|
|
|||
| public Result(String filename, Long fileByteSize, DestinationT destination) { | |||
| checkNotNull(destination); | |||
There was a problem hiding this comment.
Next time, I'd suggest this.destination = checkNotNull(destination).
Sholudn't the filename and fileByteSize also be non-nullable?
bjchambers
reviewed
Jun 5, 2017
| @@ -126,8 +129,8 @@ public void processElement(ProcessContext c) throws Exception { | |||
| // Return a null destination in this case - the constant DynamicDestinations class will | |||
There was a problem hiding this comment.
This comment is out of date -- it doesn't return a null destination, it returns the default destination according to dynamiDestinations.getDestination(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing to an empty table, BigQueryIO was throwing a NPE because WritePartitions was returning null. This was a regression in previous behavior.
R: @jkff