Use SDK harness container for FnAPI jobs when worker_harness_containe…

[tvalentyn]

…r_image is not specified. By default the image tag corresponds to the version of the release, same as for legacy images.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

• Make sure the PR title is formatted like:
  [BEAM-<Jira issue #>] Description of pull request
• Make sure tests pass via mvn clean verify.
• Replace <Jira issue #> in the title with the actual Jira issue
  number, if there is one.
• If this contribution is large, please file an Apache
  Individual Contributor License Agreement.

---

[tvalentyn]

R: @aaltay

[aaltay]

R: @charlesccychen

get_required_container_version is the right place to update.

[charlesccychen]

Can you please update dependency.py as Ahmet suggested? Thanks!

[tvalentyn]

Thanks, I moved the logic to dependency.py. I think get_required_container_version is currently meant to return just the version(tag) of the image, so I left it as is and added another function.
PTAL

[aaltay]

@tvalentyn There is a lint error. Also could you please rebase your change?

[coveralls]

Coverage increased (+0.006%) to 70.879% when pulling 3ffab61 on tvalentyn:default_container_name into 0b19fb4 on apache:master.

[tvalentyn]

@aaltay Thanks for heads-up. PTAL.

[coveralls]

Coverage increased (+0.02%) to 70.896% when pulling 6360318 on tvalentyn:default_container_name into 0b19fb4 on apache:master.

[aaltay]

Tests are failing. Could you look at that?

[coveralls]

Coverage increased (+0.007%) to 70.874% when pulling 4232943 on tvalentyn:default_container_name into 16f8000 on apache:master.

[coveralls]

Coverage increased (+0.01%) to 70.877% when pulling 4232943 on tvalentyn:default_container_name into 16f8000 on apache:master.

[tvalentyn]

Thanks, my bad. PTAL

[charlesccychen]

Can you also please squash the messy commit tree here so that it is one commit on top of master?

[charlesccychen]

Please follow this style guide for structured pydocs when specifying argument / return types: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html (see the other possible style guides here: https://stackoverflow.com/questions/34331088/how-to-comment-parameters-for-pydoc)

[charlesccychen]

Please add TODO to refactor job types into an enum-like class.

[coveralls]

Coverage increased (+0.007%) to 70.874% when pulling e6115f0 on tvalentyn:default_container_name into 16f8000 on apache:master.

[coveralls]

Coverage increased (+0.02%) to 70.884% when pulling e6115f0 on tvalentyn:default_container_name into 16f8000 on apache:master.

[tvalentyn]

Let's drop this in favor of #3468