Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2521] Select SDK distribution based on the selected SDK name #3474

Closed
wants to merge 2 commits into from
Closed

[BEAM-2521] Select SDK distribution based on the selected SDK name #3474

wants to merge 2 commits into from

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Jun 29, 2017

tvalentyn
tvalentyn reviewed Jun 29, 2017
View reviewed changes
sdks/python/apache_beam/runners/dataflow/internal/dependency.py

# In a released version BEAM_CONTAINER_VERSION and BEAM_FNAPI_CONTAINER_VERSION
# should match each other, and should be in the same format as the SDK version
# (i.e. MAJOR.MINOR.PATCH). For non-released (dev) versions, read below.
# Update this version to the next version whenever there is a change that will
# require changes to legacy Dataflow worker execution environment.
# This should be in the beam-[version]-[date] format, date is optional.
Copy link
Contributor

@tvalentyn tvalentyn Jun 29, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lines 81, 82 since they repeat in 75?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tvalentyn
tvalentyn approved these changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 70.878% when pulling 40f8551 on aaltay:dist2 into bf5aa1b on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.875% when pulling 40f8551 on aaltay:dist2 into bf5aa1b on apache:master.

@asfgit asfgit closed this in 99b5b05 Jun 29, 2017
@aaltay aaltay deleted the dist2 branch August 28, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvalentyn tvalentyn tvalentyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaltay @coveralls @tvalentyn