Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2556] Implement retries in the read connector. #3558

Merged
merged 1 commit into from Jul 13, 2017
Merged

[BEAM-2556] Implement retries in the read connector. #3558

merged 1 commit into from Jul 13, 2017

Conversation

cph6
Copy link
Contributor

@cph6 cph6 commented Jul 13, 2017

Retry failed RunQuery calls.
Respect non-retryable error codes from Datastore.
Add unit tests to check that retryable errors are retried.

Implement retries in the read connector.
016baf3 
Respect non-retryable error codes from Datastore.
Add unit tests to check that retryable errors are retried.
@cph6
Copy link
Contributor Author

cph6 commented Jul 13, 2017

R: @vikkyrk
R: @ssisk

This is loosely related to my previous change — this ensures that non-retryable errors can be returned quickly without getting tied up in the retry & client-side backoff behaviour. I updated the read connector at the same time.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.701% when pulling 016baf3 on cph6:datastore_better_error_handling into 66b4a1b on apache:master.

@vikkyrk
Copy link
Contributor

vikkyrk commented Jul 13, 2017

LGTM

@vikkyrk
Copy link
Contributor

vikkyrk commented Jul 13, 2017

R: @chamikaramj for merging.

@chamikaramj
Copy link
Contributor

LGTM. Merging.

@asfgit asfgit merged commit 016baf3 into apache:master Jul 13, 2017
asfgit pushed a commit that referenced this pull request Jul 13, 2017
@chamikaramj
This closes #3558
889776f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cph6 @coveralls @vikkyrk @chamikaramj @asfgit