[BEAM-2640, BEAM-2641] Introduces TextIO/AvroIO.read().withHintMatchesManyFiles() #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling a3a4e86 on jkff:textio-readall into ** on apache:master**. |
|
Since #3615 was submitted, the current PR should be updated to include AvroIO.read().withHintMatchesManyFiles(). |
jkff
changed the title
|
OK, now this also includes AvroIO.read().withHintMatchesManyFiles(), PTAL. |
|
Changes Unknown when pulling ff3adf3 on jkff:textio-readall into ** on apache:master**. |
I also converted DatastoreV1 to use this overload, and, as an exercise, added a withQuery(ValueProvider) overload to JdbcIO.
In that case it expands to TextIO.readAll().
|
retest this please |
1 similar comment
|
retest this please |
|
Alternatively R: @lukecwik |
reuvenlax
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reincarnation of #3598 which got closed by accident
In that case it expands to TextIO.readAll(). Implementing this when the filepattern is a ValueProvider nudged me to also implement BEAM-2640 - Create.ofProvider(ValueProvider).
Links:
https://issues.apache.org/jira/browse/BEAM-2640
https://issues.apache.org/jira/browse/BEAM-2641
R: @reuvenlax CC: @sammcveety