Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2431] Add GRPC to Compilation of the Runner API #3687

Closed
wants to merge 1 commit into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Aug 4, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Generates the JobService GRPC classes.

Generates the JobService GRPC classes.
@tgroh
Copy link
Member Author

tgroh commented Aug 4, 2017

R: @sb2nov

@sb2nov
Copy link
Contributor

sb2nov commented Aug 4, 2017

LGTM if tests pass.

@tgroh
Copy link
Member Author

tgroh commented Aug 4, 2017

retest this please

1 similar comment
@tgroh
Copy link
Member Author

tgroh commented Aug 7, 2017

retest this please

@tgroh
Copy link
Member Author

tgroh commented Aug 7, 2017

AMQPIOTest seems to be timing out; I don't believe the two are related, but I'm going to give it one more go before investigating further.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.975% when pulling 006db74 on tgroh:job_submission_api_java into f731de0 on apache:master.

@asfgit asfgit closed this in 086ec77 Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants