Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][BEAM-2784] Run python 2 to 3 migration and fix resulting Python 2 errors #3772

Commits on Aug 27, 2017

  1. Configuration menu
    Copy the full SHA
    897fbac View commit details
    Browse the repository at this point in the history
  2. Fix up the errors introduced by the automatic conversion. This is a s…

    …quash of a somewhat long process to fix all of these:
    
    Start manually fixing up the errors.
    
    Explicitly depend on the future package
    
    Attempt to fix encoder issues
    
    List was doing nothing
    
    Use has_attr func correctly
    
    More fixes
    
    Set default encoding to latin-1 in some places since otherwise we run into issues with using strings to hold codepoint above 128. Switch coder_impl to check for basestring
    
    Future holden says thanks for basestirng
    
    Use Bytes IO for avroio
    
    Try and fix assertItemsEqual py2 again
    
    be explicit about newint
    
    sys + b string
    
    sys import
    
    Explicit encode before putting into a pb2
    
    Use BytesIO
    
    Add missing import
    
    Fix newint tuple magic
    
    force positions to int
    
    Add ignore unicode prefix annotation from Spark
    
    Try assertItemsEqual again
    
    Stream change
    
    More coder fixes
    
    Rewrite exception messages for newint to int so we can be consistent between Py2 and Py3 with the type inferance
    
    try converting to a string early idk
    
    Progress around type hints being finicky now that we have future
    
    Move _rewrite_typehint_string around, try and cleanup some builtin imports
    
    Tentative: use basestring for str in Py2 which is a bit sketchy
    
    Remove from builtins import str and minor fixes
    
    Fix some more coding issues
    
    Add an explicit test for the new coder, include the new method from the changed inheritance, add workaround for unicode.
    
    Second missing next
    
    Change some ptransform tests
    
    Fix the unicode workaround import (oops)
    
    Fix raising the error during retry
    
    Ok so it "works" for the one test we've been iterating on but has lots of print debugging cause ohgod
    
    Remove a bunch of cruft debugging added in and some things that took us down the wrong path as well with intermediate helper transform type annotations
    
    Keep repr as is
    
    Make SequenceTypeConstraint an instance of IndexableTypeConstraint. Add explicit tests in trivial_inference_test for indexing. Now at 1260 tests passing and 256 skipped :)
    
    Small gcp related fixes
    
    gcsio test fixes
    
    gcsio and pylint fixes
    
    Import order fix
    
    autopep8 W391,W293,W291,E306,E305,E304,E303
    
    We don't support 3.4 yet
    
    Fix workaround for object magic
    
    Ok so the underlying transfer library is using six so lets use it too
    
    Ok make the tests more like normal
    
    Add in missing return and factor out format result since long line
    holdenk committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    7527e21 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd7e623 View commit details
    Browse the repository at this point in the history
  4. Add in missing test_utils

    holdenk committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    d1b11c8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2017

  1. Fix more pylint issues

    holdenk committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    7d71f58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43ad4fa View commit details
    Browse the repository at this point in the history
  3. Style fixes

    holdenk committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    ee53265 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bdffa73 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b29aff0 View commit details
    Browse the repository at this point in the history