[BEAM-1347] Create value state, combining state, and bag state views over the BagUserState. #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over the BagUserState. Also bind the state persistence to the end of finishBundle.
|
R: @vikkyrk |
vikkyrk
reviewed
Aug 30, 2017
| * <p>TODO: Add support for {@link #bindMap} and {@link #bindSet}. Note that | ||
| * {@link #bindWatermark} should never be implemented. | ||
| */ | ||
| private class BeamFnStateBinder implements StateBinder { |
There was a problem hiding this comment.
Wondering if its better to move this class to its own file and making package private, so that it would be easier if we wanted to reuse it or add its own tests. Also improves readability of the FnApiDoFnRunner class.
There was a problem hiding this comment.
That can happen once there is a need for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Also bind the state persistence to the end of finishBundle.