[BEAM-3065] Avoids generating proto files for Windows if grpcio-tools is not installed. #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @robertwb |
robertwb
reviewed
Oct 18, 2017
sdks/python/gen_protos.py
Outdated
| @@ -76,6 +77,14 @@ def generate_proto_files(force=False): | |||
| try: | |||
| from grpc_tools import protoc | |||
| except ImportError: | |||
| if platform.system() == 'Windows': | |||
| # For Windows, grpcio-tools has to be installed manually. | |||
| logging.warning( | |||
There was a problem hiding this comment.
Raise this as an exception. Otherwise the build will "succeed" and they'll get much harder to diagnose errors later.
chamikaramj
commented
Oct 18, 2017
sdks/python/gen_protos.py
Outdated
| @@ -76,6 +77,14 @@ def generate_proto_files(force=False): | |||
| try: | |||
| from grpc_tools import protoc | |||
| except ImportError: | |||
| if platform.system() == 'Windows': | |||
| # For Windows, grpcio-tools has to be installed manually. | |||
| logging.warning( | |||
There was a problem hiding this comment.
robertwb wrote:
Raise this as an exception. Otherwise the build will "succeed" and they'll get much harder to diagnose errors later.
Done.
robertwb
approved these changes
Oct 18, 2017
sdks/python/gen_protos.py
Outdated
| 'Cannot generate protos for Windows since grpcio-tools package is ' | ||
| 'not installed. Please install this package manually ' | ||
| 'using \'pip install grpcio-tools\'.') | ||
| return |
There was a problem hiding this comment.
Remove this redundant return.
chamikaramj
commented
Oct 18, 2017
sdks/python/gen_protos.py
Outdated
| 'Cannot generate protos for Windows since grpcio-tools package is ' | ||
| 'not installed. Please install this package manually ' | ||
| 'using \'pip install grpcio-tools\'.') | ||
| return |
There was a problem hiding this comment.
robertwb wrote:
Remove this redundant return.
Done.
|
Run Python PreCommit |
2 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.