[BEAM-2718] Integrate bundle retry code for the DirectRunner #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaltay
reviewed
Nov 11, 2017
sdks/python/run_pylint.sh
Outdated
| @@ -72,6 +72,7 @@ ISORT_EXCLUDED=( | |||
| "iobase_test.py" | |||
| "fast_coders_test.py" | |||
| "slow_coders_test.py" | |||
| "executor.py" | |||
There was a problem hiding this comment.
What is the problem with isort in this file?
mariapython
force-pushed
the
direct-bundle-retry-mandatory
branch
from
59f2c74
to
580cbd8
Compare
mariapython
force-pushed
the
direct-bundle-retry-mandatory
branch
from
580cbd8
to
907a7da
Compare
mariapython
commented
Nov 11, 2017
sdks/python/run_pylint.sh
Outdated
| @@ -72,6 +72,7 @@ ISORT_EXCLUDED=( | |||
| "iobase_test.py" | |||
| "fast_coders_test.py" | |||
| "slow_coders_test.py" | |||
| "executor.py" | |||
There was a problem hiding this comment.
aaltay wrote:
What is the problem with isort in this file?
It was complaining about the wrong import order for some reason. I have tried again without and it works without excluding the file.
charlesccychen
approved these changes
Nov 11, 2017
sdks/python/run_pylint.sh
Outdated
| @@ -72,6 +72,7 @@ ISORT_EXCLUDED=( | |||
| "iobase_test.py" | |||
| "fast_coders_test.py" | |||
| "slow_coders_test.py" | |||
| "executor.py" | |||
There was a problem hiding this comment.
mariapython wrote:
It was complaining about the wrong import order for some reason. I have tried again without and it works without excluding the file.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing of a bundle fails, the bundle is retried.