Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] add a java profile to be able to skip python/go when not relevant for current work #4173

Closed
wants to merge 1 commit into from

Conversation

rmannibucau
Copy link
Contributor

Often working on a feature or even more on a fix you only care about a language - which is probably most of the time java?

When building the project, the python execution time is very important (like half of it on my machine). However you are sure you didn't affect it since the code is quite parallel and almost unrelated in term of dependency.

This PR adds a java profile which skips python/go sdk when building. It is designed to be activable through a property you can put in your settings.xml if you always only work with java part of beam.

@xumingming
Copy link
Contributor

I like this idea.

@jkff
Copy link
Contributor

jkff commented Nov 27, 2017

Seems like a good idea, though please bring it up on the mailing list - I think it's been discussed before and it'd be good if people who participated in that discussion chimed in. As a workaround, I typically use -pl sdks/java/core -am -amd.

@reuvenlax
Copy link
Contributor

R: @lukecwik

@lukecwik
Copy link
Member

Note that the sdks/java/container module has a dependency on go code, but it doesn't look like a maven dependency. Note that this will be brittle in the long run as more cross language dependencies develop and our migration to Gradle will make this moot.

I'll merge since this genuinely may help some developers, otherwise please close this PR.

@robertwb
Copy link
Contributor

Often working on a feature or even more on a fix you only care about a language - which is probably most of the time java?

You mean probably most of the time Python, right :)?

Ideally this could be deduced via dependencies, e.g. we should be able to say "test everything that depends on anything that's changed (according to git?).

@rmannibucau
Copy link
Contributor Author

When writing these lines runners where all java based so java build path was shorter than other languages which were just bridges to java. Not sure it is still the case but having mono language "build views" is important to keep being "contributable". Inded I care more of java but it is true for all languages I think.

We can close this PR if gradle makes it smoother - theorically yes but didnt get time to check to be honest.

@rmannibucau
Copy link
Contributor Author

Closing for now, let's see how it goes when the full switch to gradle is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants