[BEAM-2899] Implement most of JobApi#run #4188
Conversation
|
CC: @herohde |
tgroh
force-pushed
the
job_service_run
branch
from
e5b20ee
to
32acc81
Compare
runners/reference/java/pom.xml
Outdated
| <artifactId>beam-runners-reference-java</artifactId> | ||
|
|
||
| <name>Apache Beam :: Runners :: Reference :: Java</name> | ||
|
|
|
|
||
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> |
There was a problem hiding this comment.
Dependencies between build.gradle and pom.xml here don't match on protobuf-java/jsr305/hamcrest core/junit/slf4j-jdk14/slf4j-api. Please prune unneeded dependencies and also do we need to use provided dependencies?
tgroh
force-pushed
the
job_service_run
branch
from
32acc81
to
5b959d3
Compare
|
Updated dependencies on both ends. |
|
Did you forget to push an update, I still see hamcrest in runners/reference/java/pom.xml but not in runners/reference/java/build.gradle? |
tgroh
force-pushed
the
job_service_run
branch
from
5b959d3
to
1d35178
Compare
|
Somehow I missed something. Updated. |
runners/reference/java/build.gradle
Outdated
| shadow library.java.slf4j_api | ||
| testCompile library.java.junit | ||
| testCompile library.java.slf4j_jdk14 | ||
| testCompile library.java.hamcrest |
There was a problem hiding this comment.
library.java.hamcrest_core?
Applying build_rules.gradle to beam-runners-reference-java
applyJavaNature with default configuration for project beam-runners-reference-java
FAILURE: Build failed with an exception.
-
Where:
Build file '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_GradleBuild/src/runners/reference/java/build.gradle' line: 30 -
What went wrong:
A problem occurred evaluating project ':beam-runners-parent:beam-runners-reference-parent:beam-runners-reference-java'.
Cannot convert a null value to an object of type Dependency.
The following types/formats are supported:
- Instances of Dependency.
- String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
- Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
- FileCollections, for example files('some.jar', 'someOther.jar').
- Projects, for example project(':some:project:path').
- ClassPathNotation, for example gradleApi().
This runs a Pipeline via the Portability Framework. This runner is not yet implemented. This change exists to construct the appropriate module.
tgroh
force-pushed
the
job_service_run
branch
from
1d35178
to
e46ef2e
Compare
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.