[BEAM-3008] Adds BigtableOptions configurator to the BigtableIO #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecates previous BigtableOptions providing methods.
sduskis
reviewed
Dec 4, 2017
| * .setProjectId("project") | ||
| * .setInstanceId("instance") | ||
| * .withProjectId("project") | ||
| * .withInstanceId("instance") | ||
| * .withTableId("table")); | ||
| * }</pre> | ||
| * | ||
| * <h3>Using local emulator</h3> |
There was a problem hiding this comment.
Can you please remove the whole Using local emulator section. It's not right anymore.
sduskis
approved these changes
Dec 4, 2017
| @@ -438,6 +474,8 @@ public String toString() { | |||
| .add("tableId", getTableId()) | |||
| .add("keyRange", getKeyRange()) | |||
| .add("filter", getRowFilter()) | |||
| .add("bigtableOptionsConfiguratorProvided", | |||
There was a problem hiding this comment.
It's worth printing out the options themselves post configurator. Printing the configurator class might be worth while as well.
- Adds iinfo to toString and populateDisplayData about effective BigtableOptions
|
@sduskis I have organized them for now in single function but it caused the code duplication, once we move it to the BigtableConfig, it would be much nicer. I am not sure that we would be able to populate toString with data once we switch to ValueProviders because we might not have values in time when toString might be called, for populate display data should be fine. |
sduskis
approved these changes
Dec 6, 2017
|
Hi @chamikaramj, please merge this PR, @sduskis approved it. Thanks. |
|
LGTM. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.