Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3042] Renaming properties form IO target counter name. #4241

Merged
merged 1 commit into from Dec 12, 2017

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Dec 11, 2017

These metrics will be used internally to track Bytes read and time spent reading both side inputs and shuffle. This rename is to match the internal dataflow design for these metrics.

This is to make them match with the redesign of internal Dataflow intertransform metrics.
@pabloem
Copy link
Member Author

pabloem commented Dec 11, 2017

r: @aaltay
This change is for an internal project for dataflow insights. Let me know if the change looks reasonable.

@aaltay
Copy link
Member

aaltay commented Dec 11, 2017

LGTM

@aaltay aaltay merged commit b97df71 into apache:master Dec 12, 2017
@pabloem pabloem deleted the patch-2 branch December 12, 2017 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants