[BEAM-3388] Type-specialize custom decoders and encoders in Go SDK runtime #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @wcn3 |
wcn3
reviewed
Dec 22, 2017
|
|
||
| // RegisterDecoder registers an custom decoder invoker for the given type, | ||
| // such as "func(int)[]byte". If multiple decoder invokers are registered | ||
| // for the same type, the last registration wins. |
There was a problem hiding this comment.
Should we at least log a warning we're clobbering a registration? That would help a user in the case where they aren't getting the coder behavior they expect. Bonus points if we retain the filename and line of code that performed the registration.
wcn3
approved these changes
Dec 22, 2017
|
Ups. Accidentally messed up this branch. I'll resend the PR and address the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the reflective overhead for custom encoders and decoders of certain types. This is a "poor man's templates" approach.
Once #4289 is in, I'll change the element coding to not reinspect the coder structure for each element. That will both speed things up and avoid memory reallocations.