[BEAM-3388] Avoid various reflection and re-processing in the Go SDK runtime #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @wcn3 |
|
Any comments or concerns? |
wcn3
reviewed
Jan 9, 2018
| inputs[key] = maker | ||
| } | ||
|
|
||
| type reIterValue struct { |
There was a problem hiding this comment.
This casing seems incorrect. Camel-casing is general used to mark word boundaries, but here, it's emphasizing the prefix 're'. I think this should be 'reiterValue'
There was a problem hiding this comment.
The name is also meant to match the "ReIter" constant. If both should be "Reiter" then we should probably come up with a better name altogether. I prefer to address such a change in a separate PR.
There was a problem hiding this comment.
I don't have a great suggestion here. I agree this comment is not a blocker for this PR.
wcn3
approved these changes
Jan 9, 2018
|
Thanks! |
|
R: @robertwb (merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.