[BEAM-3552] Support Python 3 in the metrics, internal, typehints, and utils modules. #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
reviewed
Jan 29, 2018
| @@ -60,8 +60,8 @@ def test_non_function(self): | |||
| [1, 2, 3] | beam.Map(str.upper) | |||
|
|
|||
| def test_loose_bounds(self): | |||
| @typehints.with_input_types(typehints.Union[int, float, long]) | |||
| @typehints.with_output_types(basestring) | |||
| @typehints.with_input_types(typehints.Union[int, float, int]) | |||
| @typehints.with_input_types(typehints.Union[int, float, long]) | ||
| @typehints.with_output_types(basestring) | ||
| @typehints.with_input_types(typehints.Union[int, float, int]) | ||
| @typehints.with_output_types(type) |
|
Great, I've made the changes and squashed it down to 1 commit. |
|
Hi @robertwb, I've resolved recent merge conflicts. The unit tests that don't pass in Python 3 are the trivial inference tests and the ones in utils/ regarding using rich comparisons instead cmp (blocked by the Cython version). |
|
Thanks! We should consider how we're going to test these to keep it working going forward. |
|
Great, I will add JIRA issues regarding the problems remaining in the above modules. I don't have too much experience with this type of migration, but t seems that until we can get rid of all major blockers (SyntaxError, NameError, ImportError, etc.) in the modules, it will be hard to test that Beam works correctly on Python3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[] Each commit in the pull request should have a meaningful subject line and body.
[] Format the pull request title like
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.[] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[] Run
mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.If this contribution is large, please file an Apache Individual Contributor License Agreement.
Ensures that the unit tests in these modules which don't depend on other modules pass.
The changes include: