[BEAM-1251] Use six.integer_types #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertwb I have a hard time making sense of the Jenkins output. What have I done wrong here? |
|
Jenkins is quite java centric. For Python, you have to look at the console
output (on the right). Here it appears you have a lint error, run "tox -e
lint" locally to reproduce.
…On Thu, Feb 1, 2018 at 3:05 PM, cclauss ***@***.***> wrote:
@robertwb <https://github.com/robertwb> I have a hard time making sense
of the Jenkins output. What have I done wrong here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4571 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdqgcMh_FNhRP23SSSU-s75GBzVFSPdks5tQkMqgaJpZM4R2TWc>
.
|
|
Were you able to figure this out? |
cclauss
force-pushed
the
from-six-import-integer_types
branch
from
9e4f27b
to
570cfaa
Compare
|
It was... Running pylint for module apache_beam: |
cclauss
force-pushed
the
from-six-import-integer_types
branch
from
570cfaa
to
0b0c85f
Compare
cclauss
force-pushed
the
from-six-import-integer_types
branch
from
0b0c85f
to
e6e875d
Compare
|
Jenkins: retest this please. |
robertwb
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://six.readthedocs.io/#six.integer_types
long was dropped from Python 3 so in the PR we replace all copies of isinstance(x, (int, long)) with isinstance(x, integer_types) which will do the right thing on both Python 2 and Python 3.