[BEAM-3644] Disable verbose typecoder warnings. #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesccychen
approved these changes
Feb 8, 2018
| # We explicitly want the fallback coder. | ||
| pass | ||
| elif isinstance(typehint, typehints.TypeVariable): | ||
| # TODO(robertwb): Clean this up when type inference is fully enabled. | ||
| pass | ||
| else: | ||
| warnings.warn('Using fallback coder for typehint: %r.' % typehint) | ||
| # TODO(robertwb): Re-enable this warning when it's actionable. |
There was a problem hiding this comment.
Thanks! Can you file a JIRA to track investigating what is actionable?
|
LGTM. |
These are mostly noise for end-users, but are a lot more frequent for non-direct runners that actually use coders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly noise for end-users, but are a lot more frequent
for non-direct runners that actually use coders.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.