[BEAM-3671] Beam runner inventory #4677
Conversation
alanmyrvold
changed the title
alanmyrvold
changed the title
|
@alanmyrvold, is this something you would want to check in? You would be able to run it from Jenkins manually. |
| // Set common parameters. | ||
| common_job_properties.setTopLevelMainJobProperties(delegate) | ||
|
|
||
| // Sets that this is a PostCommit job. |
There was a problem hiding this comment.
PostCommit and Cron seem like they shouldn't really be in the same category, if we want to run inventory regularly, independently of changes (which seems appropriate)
(I recognize that this isn't introduced here and shouldn't be a blocker, but it's worth noting)
There was a problem hiding this comment.
Fixed. Added a method in common, setCronJob and called that instead.
|
@lukecwik - yes, I'd want this checked in so it runs regularly. |
|
@tgroh - updated based on feedback. PTAL? |
There was a problem hiding this comment.
Right now this will just drop everything into the console, right? so it's more akin to logging than alerting if a machine doesn't have the 'proper' inventory.
Do we have any plan to have a more heterogeneous fleet, or machine capabilities for executing our builds, or a dashboard? Should we, if not, and is that tracked anywhere?
This LGTM regardless
Inventory software on each beam executor to validate all are set up consistently
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.