[BEAM-3690] ban mockito-all and hamcrest-all #4712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukecwik , The purpose of this change is to configure the maven enforcer plugin to ban hamcrest-all/mockito-all using https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html. |
lukecwik
requested changes
Feb 21, 2018
sdks/java/nexmark/pom.xml
Outdated
| </goals> | ||
| <configuration> | ||
| <ignoredUnusedDeclaredDependencies> | ||
| <ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest-library:jar:${hamcrest.version}</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
This seems to duplicate the lines below.
Are they needed?
lukecwik
requested changes
Feb 23, 2018
sdks/java/nexmark/pom.xml
Outdated
| </goals> | ||
| <configuration> | ||
| <ignoredUnusedDeclaredDependencies> | ||
| <ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest-library:jar:${hamcrest.version}</ignoredUnusedDeclaredDependency> |
|
Note that we don't use tabs for indentation. I am cleaning up/flattening this PR and merging. |
lukecwik
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://issues.apache.org/jira/browse/BEAM-3690
ban mockito-all and hamcrest-all