Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4150] Augment Python SDK worker to handle unwindowed coders. #4867

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

robertwb
Copy link
Contributor

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@robertwb robertwb requested a review from aljoscha March 14, 2018 05:58
@robertwb
Copy link
Contributor Author

R: @axelmagn, @aljoscha . This should help with some of the errors when trying to run on Flink.

@herohde
Copy link
Contributor

herohde commented Mar 16, 2018

@robertwb Is there a JIRA for this work? (I'm asking assuming similar work is needed for the Go SDK)

@robertwb robertwb changed the title Augment Python SDK worker to handle unwindowed coders. [BEAM-4150] Augment Python SDK worker to handle unwindowed coders. Apr 20, 2018
@robertwb
Copy link
Contributor Author

I couldn't find a JIRA, so I created one.

@herohde yes, Go will need to do the same (if it doesn't already).

@axelmagn, could you please take a look?

@herohde
Copy link
Contributor

herohde commented Apr 20, 2018

Thanks @robertwb -- it does this as part of the Go windowing PR.

@robertwb
Copy link
Contributor Author

Jenkins: retest this please.

@tweise tweise merged commit 5b79148 into apache:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants