[BEAM-3798] Remove error check on dataflow when getting batch job state #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TestDataflowRunner beam can rely solely on Dataflow job state (for batch jobs). It it's "DONE", then it means that Dataflow handled any errors on it's own (eg. by retrying failed bundles). We don't need to throw them further. This PR does not fix a streaming scenario. We should fix it on separate PR later. It still fixes Performance tests that we have now.
|
Run Dataflow ValidatesRunner |
|
@lukecwik could you take a look? |
lukecwik
approved these changes
Mar 15, 2018
lgajowy
deleted the
BEAM-3798_fix_performance_test_flakiness_on_dataflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TestDataflowRunner beam can rely solely on Dataflow job state (for
batch jobs). It it's "DONE", then it means that Dataflow handled any
errors on it's own (eg. by retrying failed bundles). We don't need to
throw them further.
This PR does not fix a streaming scenario. We should fix it on separate
PR later. It still fixes Performance tests that we have now.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.