Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-3866] Remove windowed value requirement for Go SDK External #4919

Merged
merged 1 commit into from Mar 21, 2018
Merged

[BEAM-3866] Remove windowed value requirement for Go SDK External #4919

merged 1 commit into from Mar 21, 2018

Conversation

herohde
Copy link
Contributor

@herohde herohde commented Mar 21, 2018

  • Updated remaining W<> comments.
  • Added missing registration of addFixedKeyFn.

@herohde herohde changed the title [BEAM-3866] Remove windowed value requirement for External [BEAM-3866] Remove windowed value requirement for Go SDK External Mar 21, 2018
@herohde
Copy link
Contributor Author

herohde commented Mar 21, 2018

R: @lostluck

@herohde
Copy link
Contributor Author

herohde commented Mar 21, 2018

Thanks!

R: @tgroh

@tgroh
Copy link
Member

tgroh commented Mar 21, 2018

LGTM

@tgroh tgroh merged commit 75c58a0 into apache:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostluck lostluck lostluck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@herohde @tgroh @lostluck