[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
herohde
commented
Apr 4, 2018
herohde
commented
- Added a new test category to exclude ParDoLifecycleTest
herohde
force-pushed
the
gradle
branch
2 times, most recently
from
f4fecb9
to
1160bcd
Compare
|
Run seed job |
lukecwik
requested changes
Apr 4, 2018
| testClassesDirs = files(project(":sdks:java:core").sourceSets.test.output.classesDirs) | ||
| useJUnit { | ||
| includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner' | ||
| excludeCategories 'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders' |
There was a problem hiding this comment.
These seem like the wrong exclude categories when compared to
Line 72 in 5caa883
| /** | ||
| * Category tag for the ParDoLifecycleTest for exclusion (BEAM-3241). | ||
| */ | ||
| public class UsesParDoLifecycle {} |
runners/gearpump/build.gradle
Outdated
| validatesRunner project(path: project.path, configuration: "shadow") | ||
| } | ||
|
|
||
| task validatesRunnerStreaming (type: Test) { |
There was a problem hiding this comment.
nit: spacing validatesRunnerStreaming ( -> validatesRunnerStreaming(
runners/apex/build.gradle
Outdated
| @@ -73,5 +82,31 @@ task buildDependencyTree(type: DependencyReportTask) { | |||
| } | |||
| compileJava.dependsOn buildDependencyTree | |||
|
|
|||
| task validatesRunnerBatch (type: Test) { | |||
There was a problem hiding this comment.
nit: spacing validatesRunnerBatch ( -> validatesRunnerBatch(
|
Thanks @lukecwik. PTAL |
|
Run seed job |
lukecwik
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.