Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-3249] Only generate all artifacts when publishing. #5103

Merged
merged 1 commit into from Apr 11, 2018

Conversation

lukecwik
Copy link
Member

This removes enableShadow since the user can now pass in the shading configuration closure explicitly.

Had to re-add propdeps-maven since it was supplying a task needed for uploadingArtifacts (which is part of the old 'maven' plugin). It seems like we are mixing stuff from the old 'maven' and the new 'maven-publish' tasks which requires further investigation.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lukecwik lukecwik requested a review from aaltay April 11, 2018 18:38
This removes enableShadow since the user can now pass in the shading configuration closure explicitly.
@lukecwik lukecwik merged commit 13a65c6 into apache:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants