Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-4088] fix thread leak in tests on PR #4965 #5231

Merged
merged 4 commits into from
Apr 30, 2018
Merged

[BEAM-4088] fix thread leak in tests on PR #4965 #5231

merged 4 commits into from
Apr 30, 2018

Conversation

echauchot
Copy link
Contributor

@echauchot echauchot commented Apr 26, 2018 •
edited

This PR is based on @rmannibucau's #4965 that fixes a thread leak in direct runner. It just fixes its tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@echauchot echauchot force-pushed the BEAM-4088-fix-gradle-thread-leak branch from bba09f1 to d8a03e0 Compare April 26, 2018 15:45
@echauchot
Copy link
Contributor Author

R: @rmannibucau

@echauchot echauchot mentioned this pull request Apr 26, 2018
Closed
10 tasks
rmannibucau
rmannibucau approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echauchot
Copy link
Contributor Author

Run Java PreCommit

@echauchot echauchot force-pushed the BEAM-4088-fix-gradle-thread-leak branch from d8a03e0 to 1404ff2 Compare April 30, 2018 13:28
@echauchot echauchot merged commit ffafc61 into apache:master Apr 30, 2018
@echauchot echauchot deleted the BEAM-4088-fix-gradle-thread-leak branch May 14, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@echauchot @rmannibucau