[BEAM-4231] Runner utility for coder instantiation #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tgroh |
tgroh
reviewed
May 3, 2018
|
|
||
| /** Helpers to construct coders for gRPC port reads and writes. */ | ||
| public class WireCoders { | ||
| /** Creates an SDK-side wire coder for a port read/write for the given PCollection. */ | ||
| /** | ||
| * Creates an SDK-side wire coder for a port read/write for the given PCollection. Returns a |
There was a problem hiding this comment.
"The returned coder will be a windowed value coder containing..."
There was a problem hiding this comment.
I've added a @return clause that documents this.
tgroh
approved these changes
May 4, 2018
|
Jenkins? friend, buddy? |
|
Is Jenkins down? That didn't seem to do anything. |
|
Yeah looks like
…On Fri, May 4, 2018 at 10:59 AM Ben Sidhom ***@***.***> wrote:
Is Jenkins down? That didn't seem to do anything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5274 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAaPKiLpqthiR6cjxC3AS3wxHE-Gscfmks5tvJcYgaJpZM4Tx20o>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also slipped in some doc comment fixes.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.