[BEAM-3979] Reintroduce usage from pr/4989 #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be still failing due to worker incompatibility. |
|
retest this please |
… to the new style. This reverts commit e62d997.
reuvenlax
force-pushed
the
finish_new_dofn
branch
from
47dbadc
to
6fe837a
Compare
|
@jkff The workers are now updated, I expect this to pass. |
|
Failure in ReferenceRunner does not seem related |
jkff
approved these changes
Jun 4, 2018
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage components from pr/4989 were reverted from that PR due to compatibility issues with the Dataflow runner. Now that Dataflow is updated, reintroduce those files.