[BEAM-4411] Update Jackson version to latest to pick up security fixes. #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I converged the usage of the joda date time datatype to use the same version as Jackson since they are released together.
pabloem
approved these changes
May 25, 2018
| @@ -96,7 +96,6 @@ | |||
| <dependency> | |||
| <groupId>com.fasterxml.jackson.module</groupId> | |||
| <artifactId>jackson-module-scala_2.11</artifactId> | |||
| <version>2.8.9</version> | |||
| <scope>runtime</scope> | |||
There was a problem hiding this comment.
Is the version here somehow 'inherited' from the top level pom? Or why don't we have it here?
There was a problem hiding this comment.
It is inherited from the root pom.xml here:
Line 1275 in b807847
Anytime someone adds it explicitly, it overrides the root but in this case it is a duplicate of what was defined in the root pom.xml.
|
Run Spark ValidatesRunner |
|
Run Flink ValidatesRunner |
|
Run Apex ValidatesRunner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I converged the usage of the joda date time datatype to use the same version as Jackson since they are released together.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.