[BEAM-4426]: Addressed DataflowDistributionAccumulatorTest failure #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM. I'll merge as soon as tests pass. |
|
Unittest failed on this change @boyuanzz |
|
Fixed in commit 3d0e682. |
|
@pabloem pythonPreCommit passed |
udim
approved these changes
May 29, 2018
| @@ -71,7 +70,7 @@ def test_translate_to_histogram_with_input_0(self): | |||
|
|
|||
| def test_translate_to_histogram_with_max_input(self): | |||
| counter = DataflowDistributionCounter() | |||
| counter.add_input(sys.maxint) | |||
There was a problem hiding this comment.
FYI, sys.maxint isn't in Python 3 so we would have had to change this line sooner or later.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed DataflowDistributionAccumulatorTest failure on Windows
r: @pabloem
cc: @udim