Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-4316] Enforce ErrorProne analysis in runners-local-java-core project #5510

Merged
merged 1 commit into from May 30, 2018
Merged

[BEAM-4316] Enforce ErrorProne analysis in runners-local-java-core project #5510

merged 1 commit into from May 30, 2018

Conversation

cademarkegard
Copy link
Contributor

Adds failOnWarning: true for runners-local-java-core project and fixes the annotation warnings:

warning: Cannot find annotation method 'value()' in type 'DefaultAnnotation': class file for edu.umd.cs.findbugs.annotations.DefaultAnnotation not found

warning: Cannot find annotation method 'value()' in type 'DefaultAnnotation'

@swegner

@cademarkegard
Copy link
Contributor Author

run java precommit

1 similar comment
@iemejia
Copy link
Member

iemejia commented May 30, 2018

run java precommit

iemejia
iemejia approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@iemejia iemejia merged commit d4db2de into apache:master May 30, 2018
@cademarkegard
Copy link
Contributor Author

thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iemejia iemejia iemejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cademarkegard @iemejia