New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4310] Enforce ErrorProne analysis in runners-extensions-java-me… #5546
[BEAM-4310] Enforce ErrorProne analysis in runners-extensions-java-me… #5546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was nothing else to do than setting up deps? No errorprone failures to fix? Cool !
shadow project(path: ":beam-sdks-java-core", configuration: "shadow") | ||
shadow library.java.jackson_databind | ||
shadow library.java.jackson_datatype_joda | ||
shadow library.java.findbugs_annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand correctly you moved library.java.findbugs_annotations dep to only compile and testCompile scopes instead of all the scopes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
shadow project(path: ":beam-sdks-java-core", configuration: "shadow") | ||
shadow library.java.jackson_databind | ||
shadow library.java.jackson_datatype_joda | ||
shadow library.java.findbugs_annotations | ||
shadow library.java.findbugs_jsr305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed as you did not add any findbugs annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because otherwise error-prone does not pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging
R: @echauchot