Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4414] Create more specific namespace for each IOIT in FileBasedIOIT #5576

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

kkucharc
Copy link
Contributor

@kkucharc kkucharc commented Jun 7, 2018

Replaced a namespace with a job name parsed to have only lower case alpha-numeric characters with -.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ x ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

@kkucharc kkucharc force-pushed the namespaces-filebased-fix branch 4 times, most recently from 624fdae to c85bfd2 Compare June 7, 2018 15:17
@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run seed job

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java TextIO Performance Test HDFS

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java CompressedTextIO Performance Test HDFS

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java AvroIO Performance Test HDFS

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java MongoDBIO Performance Test

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java HadoopInputFormatIO Performance Test

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 7, 2018

Run Java PreCommit

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 8, 2018

Run seed job

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 8, 2018

Run Java XmlIO Performance Test HDFS

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 8, 2018

It created following namespaces:
beam-performancetests-avroioit-hdfs-266,
beam-performancetests-compressed-textioit-hdfs-267,
beam-performancetests-hadoopinputformat-364,
beam-performancetests-mongodbio-it-279,
beam-performancetests-textioit-hdfs-274,
beam-performancetests-xmlioit-hdfs-269.
IMO it looks ok.

@kkucharc
Copy link
Contributor Author

kkucharc commented Jun 8, 2018

@jasonkuster @lgajowy Would you take a look at this? Thanks!

@lgajowy
Copy link
Contributor

lgajowy commented Jun 8, 2018

LGTM, thanks!

This PR fixes the failing tests (AvroIOIT_HDFS, XmlIOIT_HDFS). 👍

BTW: In the future, we will probably need to refactor those Jenkins files to be divided in some more consequent way than present and addressing multiple variants of tests as there were some discussions on this topic (see here if you're interested). This is way out of scope of this PR though so you don't have to worry about this here (it's just a sidenote for the curious ;) ).

@jasonkuster jasonkuster self-requested a review June 8, 2018 16:31
@jasonkuster
Copy link
Contributor

LGTM

@jasonkuster jasonkuster merged commit 69fb5c9 into apache:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants