-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-4414] Create more specific namespace for each IOIT in FileBasedIOIT #5576
Conversation
624fdae
to
c85bfd2
Compare
7f5795a
to
727e954
Compare
Run seed job |
Run Java TextIO Performance Test HDFS |
Run Java CompressedTextIO Performance Test HDFS |
Run Java AvroIO Performance Test HDFS |
Run Java MongoDBIO Performance Test |
Run Java HadoopInputFormatIO Performance Test |
Run Java PreCommit |
Run seed job |
Run Java XmlIO Performance Test HDFS |
It created following namespaces: |
@jasonkuster @lgajowy Would you take a look at this? Thanks! |
LGTM, thanks! This PR fixes the failing tests (AvroIOIT_HDFS, XmlIOIT_HDFS). 👍 BTW: In the future, we will probably need to refactor those Jenkins files to be divided in some more consequent way than present and addressing multiple variants of tests as there were some discussions on this topic (see here if you're interested). This is way out of scope of this PR though so you don't have to worry about this here (it's just a sidenote for the curious ;) ). |
LGTM |
Replaced a namespace with a job name parsed to have only lower case alpha-numeric characters with
-
.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username
) to look at it.