Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4283] Fix naming of the BigQuery fields #5713

Merged

Conversation

echauchot
Copy link
Contributor

@echauchot echauchot commented Jun 21, 2018

Fix naming of the fields of the added BQ table. Naming error not seen in UT because of https://issues.apache.org/jira/browse/BEAM-4607

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

@echauchot echauchot requested a review from iemejia June 21, 2018 09:59
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 28209ba into apache:master Jun 21, 2018
@echauchot
Copy link
Contributor Author

thx @iemejia !

@echauchot echauchot deleted the BEAM-4283-nexmark-execution-times-to-bigquery branch July 5, 2018 09:18
charlesccychen pushed a commit to charlesccychen/beam that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants