[BEAM-4556] Enable ErrorProne analysis and -Werror for all Java projects. #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings FindBugs annotations are a mess. We want to eventually deprecate our own usage of FindBugs, but we still need to deal with the annotations because our dependencies (notable byte-buddy) use the annotations without providing the dependency. This causes compile warnings such as: byte-buddy-1.8.11.jar(/net/bytebuddy/description/type/TypeList.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found To fix these warnings, we need to include a findbugs-annotations dependency during compile which includes the SuppressFBWarnings annotation. The dependency options we currently have are: * com.google.code.findbugs:annotations:3.0.1 * Includes @SuppressFBWarnings, but licensed under LGPL * com.github.stephenc.findbugs:findbugs-annotations:1.3.9-1 * Licensed under Apache 2.0, but doesn't include @SuppressFBWarnings It is ok to use LGPL components during the build, as long as they don't make it into the distribution. See: * https://www.apache.org/legal/resolved.html#prohibited * https://www.apache.org/legal/resolved.html#optional
|
Run Python PreCommit |
|
🎆 congrats this is awesome |
|
retest this please |
iemejia
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final cleanup in the long road to enabling ErrorProne and warnings-as-errors for all Java projects.
🎆 🎆 🎆
Big thanks to everyone who helped out! @iemejia @timrobertson100 @cademarkegard @tengpeng
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)