[BEAM-3942] Remove mvn leftovers from jenkins IOIT job definitions #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run seed job |
|
Run Java MongoDBIO Performance Test |
|
Run Java JdbcIO Performance Test |
|
Run Java TextIO Performance Test HDFS |
|
Run Java AvroIO Performance Test |
lgajowy
changed the title
|
R: @iemejia Could you take a quick look? |
iemejia
reviewed
Jun 29, 2018
| beam_it_options : common_job_properties.joinPipelineOptions(pipelineOptions), | ||
| beam_extra_mvn_properties: '["filesystem=gcs"]', | ||
| bigquery_table : testConfiguration.bqTable, | ||
| benchmarks : 'beam_integration_benchmark', |
There was a problem hiding this comment.
Minor question, is this reformatting automatic? I kind of dislike having everything aligned to colons but it seems this is common in groovy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes maven leftovers that weren't removed during migration (to migrate seamlessly).
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)